Made key assertion optional for hardcoded issuing authority to avoid the need for minimal wallet server. #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halxinate
reviewed
Dec 19, 2024
| ): List<KeyPossessionChallenge> { | ||
| credentialRequestSets.add(CredentialRequestSet( | ||
| format = format!!, | ||
| keyAttestations = credentialRequests.map { it.secureAreaBoundKeyAttestation }, | ||
| keysAssertion = keysAssertion | ||
| keysAssertion = keysAssertion!! |
There was a problem hiding this comment.
It appears the null value is treated as a special forking signal now. But here (and in other similar method that signal would throw RT NPE. Is that as expected?
There was a problem hiding this comment.
Forking signal is actually in CredentialConfiguration.keyAssertionRequired. If that is true, keysAssertion must be provided. If it is null, this will throw and at some point will be converted to HTTP status 500 - not the best error code, of course, but we did not do a pass through our APIs to make sure all error codes and messages are what we want them to be.
davidz25
approved these changes
Dec 19, 2024
…the need for minimal wallet server. Signed-off-by: Peter Sorotokin <[email protected]>
sorotokin
force-pushed
the
optional-server
branch
from
6768925 to
b4fedae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DeviceAssertion validation only makes sense on the server, do not require it when creating credentials using hardcoded issuing authority (which we want to continue working without any servers). Key attestation is still required. In future we can start detecting server environment and require DeviceAssertion only when running on the server, but not in-app.
Tested manually with and without server.